geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3051) Removing obsolete SSL handling in `AcceptorImpl.accept` catch block
Date Thu, 08 Jun 2017 00:10:18 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041959#comment-16041959
] 

ASF GitHub Bot commented on GEODE-3051:
---------------------------------------

GitHub user WireBaron opened a pull request:

    https://github.com/apache/geode/pull/567

    GEODE-3051: Removing obsolete SSL handling in `AcceptorImpl.accept` c…

    …atch block
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WireBaron/geode feature/GEODE-3051

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #567
    
----
commit 9354cacfc6a8fa79746e8240730f6a209199bb89
Author: Galen O'Sullivan <gosullivan@pivotal.io>
Date:   2017-06-08T00:04:17Z

    GEODE-3051: Removing obsolete SSL handling in `AcceptorImpl.accept` catch block

----


> Removing obsolete SSL handling in `AcceptorImpl.accept` catch block
> -------------------------------------------------------------------
>
>                 Key: GEODE-3051
>                 URL: https://issues.apache.org/jira/browse/GEODE-3051
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>    Affects Versions: 1.1.1
>            Reporter: Udo Kohlmeyer
>            Assignee: Galen O'Sullivan
>
> SSL handshake is now done in a separate thread and will never reach the handler code
which is being removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message