geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2996) New flow: put/get
Date Tue, 27 Jun 2017 18:46:02 GMT


ASF GitHub Bot commented on GEODE-2996:

GitHub user WireBaron opened a pull request:

    GEODE-2996: incorporating review feedback and adding integration test

    Thank you for submitting a contribution to Apache Geode.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    - [x] Is your initial contribution a single, squashed commit?
    - [x] Does `gradlew build` run cleanly?
    - [ x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to

You can merge this pull request into a Git repository by running:

    $ git pull feature/GEODE-2996

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #605
commit 3a2d2573151d260e8f030403a03cd47c88e366bf
Author: Alexander Murmann <>
Date:   2017-06-27T00:56:06Z

    GEODE-2996: incorporating review feedback and adding integration test
    Addresses review feedback for GEODE-2996, mainly refactoring getOpertionHandler to handle
failures like the putOperationHandler
    Adding put operations to the RoundTripCacheConnectionJUnitTest, which is the integration
test for the protobuf module
    Removing service loading for protobuf operations and instead have the ProtobufStreamProcessor
populate its OperationHandlerRegistry
    Remove exception throwing from OperationHandler.process calls and remove TypeEncodingException
    Signed-off-by: Brian Rowe <>
    Signed-off-by: Alexander Murmann <>


> New flow: put/get
> -----------------
>                 Key: GEODE-2996
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
> Create proto message definitions and op handler for put/get messages.
> Client should be able to complete put/get of primitives and JSON with response.

This message was sent by Atlassian JIRA

View raw message