geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2901) Add more tests of http session replication module
Date Fri, 16 Jun 2017 00:00:02 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051215#comment-16051215
] 

ASF GitHub Bot commented on GEODE-2901:
---------------------------------------

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/584

    GEODE-2901: Adding integration tests of session replication

    Adding integration tests that test both session replications
    frameworks shipped with geode. These tests use cargo to download
    and launch different J2EE containers, so the tests can run
    against many different containers.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2901

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #584
    
----
commit 75943c5e6a1d1c9d4f23ca423f1766a0a854a5dc
Author: David Anuta <david.r.anuta@gmail.com>
Date:   2017-05-27T00:07:36Z

    GEODE-2901: Adding integration tests of session replication
    
    Adding integration tests that test both session replications
    frameworks shipped with geode. These tests use cargo to download
    and launch different J2EE containers, so the tests can run
    against many different containers.

----


> Add more tests of http session replication module
> -------------------------------------------------
>
>                 Key: GEODE-2901
>                 URL: https://issues.apache.org/jira/browse/GEODE-2901
>             Project: Geode
>          Issue Type: Improvement
>          Components: http session
>            Reporter: Dan Smith
>
> We should add more integration tests of http session replication with failover, expiration,
and multiple containers.
> We currently have some junit tests of the generic session replication module in  geode-modules-session
and a couple of dunit tests of the tomcat session module in geode-modules-tomcat8.
> However, we really want a comprehensive set of tests that run against both session modules
and multiple containers.
> I think we can get to that point if we use something like [cargo|https://codehaus-cargo.github.io/cargo/Home.html].
We could do something like the dunit tests we have where we use httpunit from the client,
but use cargo to actually launch the containers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message