geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2861) remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
Date Wed, 21 Jun 2017 15:30:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057702#comment-16057702
] 

ASF GitHub Bot commented on GEODE-2861:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/594


> remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-2861
>                 URL: https://issues.apache.org/jira/browse/GEODE-2861
>             Project: Geode
>          Issue Type: Improvement
>          Components: persistence
>    Affects Versions: 1.0.0-incubating
>            Reporter: Darrel Schneider
>            Assignee: Nick Reich
>            Priority: Trivial
>              Labels: storage_3
>
> Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting down the DiskStoreTaskPool.
> On DiskStoreImpl see these methods:
>   stopDiskStoreTaskPool
>   shutdownPool
> On GemFireCacheImpl the field diskStoreTaskPool is always null.
> Note that a bug exists in this deadcode that causes it to not call taskCancelled as it
iterates over a list of runnables. Since this code is dead it is currently doing no harm but
if the code is not removed then make sure and fix this loop.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message