geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2707) Remove TXLockToken
Date Mon, 19 Jun 2017 17:41:00 GMT


ASF GitHub Bot commented on GEODE-2707:

GitHub user YehEmily opened a pull request:

    GEODE-2707: Removing TXLockToken

    [View the JIRA ticket here.](
    It seems that there are no other classes that use the `TXLockToken` class, so it was safely
removed. It's also an internal class, so it doesn't seem likely that the removal of this class
will break any backwards compatibility.
    **_Precheckin status: In progress_**
    Thank you for submitting a contribution to Apache Geode.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
    - [ ] Is your initial contribution a single, squashed commit?
    - [ ] Does `gradlew build` run cleanly?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to

You can merge this pull request into a Git repository by running:

    $ git pull GEODE-2707

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #592
commit e51f2047136ea4cdaa09c22a3cc06290e7dd0a01
Author: YehEmily <>
Date:   2017-06-19T17:36:53Z

    GEODE-2707: Removing TXLockToken (it doesn't appear to be used anywhere, although I still
need to check for backwards compatibility issues)


> Remove TXLockToken
> ------------------
>                 Key: GEODE-2707
>                 URL:
>             Project: Geode
>          Issue Type: Task
>          Components: distributed lock service
>            Reporter: Galen O'Sullivan
>            Assignee: Emily Yeh
>            Priority: Trivial
> The {{TXLockToken}} class doesn't seem to actually be used anywhere in the source. Look
into the history and remove it if it's no longer needed.

This message was sent by Atlassian JIRA

View raw message