Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A52A7200BD3 for ; Tue, 6 Dec 2016 20:18:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A3AA0160B1B; Tue, 6 Dec 2016 19:18:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ED291160B17 for ; Tue, 6 Dec 2016 20:18:01 +0100 (CET) Received: (qmail 64718 invoked by uid 500); 6 Dec 2016 19:18:01 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 64708 invoked by uid 99); 6 Dec 2016 19:18:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 19:18:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BAF1B1AB6DE for ; Tue, 6 Dec 2016 19:18:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 9c9t1reKNkK9 for ; Tue, 6 Dec 2016 19:18:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 53FD15FCE3 for ; Tue, 6 Dec 2016 19:17:59 +0000 (UTC) Received: (qmail 64436 invoked by uid 99); 6 Dec 2016 19:17:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 19:17:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 600222C03E0 for ; Tue, 6 Dec 2016 19:17:58 +0000 (UTC) Date: Tue, 6 Dec 2016 19:17:58 +0000 (UTC) From: "Dan Smith (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-2179) GatewaySenderMBeans isConnected flag does not notice if a connection is destroyed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Dec 2016 19:18:02 -0000 [ https://issues.apache.org/jira/browse/GEODE-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726416#comment-15726416 ] Dan Smith commented on GEODE-2179: ---------------------------------- Hi Amey, My mistake, I didn't assign this one to myself. But I actually have a review request out for a fix for this issue - let me know what you think: https://reviews.apache.org/r/54330/ > GatewaySenderMBeans isConnected flag does not notice if a connection is destroyed > --------------------------------------------------------------------------------- > > Key: GEODE-2179 > URL: https://issues.apache.org/jira/browse/GEODE-2179 > Project: Geode > Issue Type: Bug > Components: wan > Reporter: Dan Smith > Assignee: Amey Barve > > The GatewaySenderMBean has a method called isConnected which ultimately calls this code in GatewaySenderEventRemoteDispatcher > {code} > @Override > public boolean isConnectedToRemote() { > return connection != null; > } > {code} > However, this doesn't take into account that the connection may be destroyed, but not null. Therefore the mbean can incorrectly indicate that the sender is connected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)