Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 727AE200BCE for ; Fri, 2 Dec 2016 20:54:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7129C160B24; Fri, 2 Dec 2016 19:54:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BC8FF160B08 for ; Fri, 2 Dec 2016 20:54:10 +0100 (CET) Received: (qmail 37165 invoked by uid 500); 2 Dec 2016 19:54:10 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 37156 invoked by uid 99); 2 Dec 2016 19:54:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 19:54:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 964F5180286 for ; Fri, 2 Dec 2016 19:54:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GaNQXCo0GU90 for ; Fri, 2 Dec 2016 19:54:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 98C8C5FBC4 for ; Fri, 2 Dec 2016 19:54:08 +0000 (UTC) Received: (qmail 31348 invoked by uid 99); 2 Dec 2016 19:52:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 19:52:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5BBB32C03DC for ; Fri, 2 Dec 2016 19:52:58 +0000 (UTC) Date: Fri, 2 Dec 2016 19:52:58 +0000 (UTC) From: "Dan Smith (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GEODE-2175) CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 02 Dec 2016 19:54:11 -0000 [ https://issues.apache.org/jira/browse/GEODE-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-2175: ----------------------------- Component/s: lucene > CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime > ----------------------------------------------------------------------------- > > Key: GEODE-2175 > URL: https://issues.apache.org/jira/browse/GEODE-2175 > Project: Geode > Issue Type: Bug > Components: lucene > Reporter: Dan Smith > > {noformat} > org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest > expectErrorAfterWaitTime FAILED > java.lang.Exception: Unexpected exception, expected but was > Caused by: > java.lang.AssertionError: expected:<1> but was:<0> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:834) > at org.junit.Assert.assertEquals(Assert.java:645) > at org.junit.Assert.assertEquals(Assert.java:631) > at org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime(TopEntriesFunctionCollectorJUnitTest.java:195) > {noformat} > Looking at this test, it looks like it's a race condition waiting to happen because it does a bunch of 1 second awaits. > I'm also suspicious of the functionality that is being tested here in the first place. A user's result collector shouldn't have to contain logic to wait for all of the results to be gather, that's handled by the function execution framework. So the real fix may be to remove these tests and the logic in TopEntriesFunctionCollector that waits for the results to be gathered. -- This message was sent by Atlassian JIRA (v6.3.4#6332)