Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B06C5200BE2 for ; Thu, 1 Dec 2016 03:03:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AF123160B19; Thu, 1 Dec 2016 02:03:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0CFE7160B13 for ; Thu, 1 Dec 2016 03:03:16 +0100 (CET) Received: (qmail 38897 invoked by uid 500); 1 Dec 2016 02:03:16 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 38888 invoked by uid 99); 1 Dec 2016 02:03:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 02:03:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C4ADCC03A4 for ; Thu, 1 Dec 2016 02:03:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mHS9cG2JFXEi for ; Thu, 1 Dec 2016 02:03:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id B77125F5C7 for ; Thu, 1 Dec 2016 02:03:14 +0000 (UTC) Received: (qmail 37076 invoked by uid 99); 1 Dec 2016 02:01:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 02:01:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 84B262C03DB for ; Thu, 1 Dec 2016 02:01:59 +0000 (UTC) Date: Thu, 1 Dec 2016 02:01:59 +0000 (UTC) From: "xiaojian zhou (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (GEODE-2161) FilterRoutingInfo.FilterInfo.toData does unneeded copying MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 01 Dec 2016 02:03:17 -0000 [ https://issues.apache.org/jira/browse/GEODE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reassigned GEODE-2161: ------------------------------------ Assignee: xiaojian zhou > FilterRoutingInfo.FilterInfo.toData does unneeded copying > --------------------------------------------------------- > > Key: GEODE-2161 > URL: https://issues.apache.org/jira/browse/GEODE-2161 > Project: Geode > Issue Type: Bug > Reporter: xiaojian zhou > Assignee: xiaojian zhou > > This is #52614 > FilterInfo.toData (that was being optimized for murex) does this: > // create a hdos > // write a bunch of stuff to it > byte[] myData = hdos.toByteArray(); > DataSerializer.writeByteArray(myData, out); > he toByteArray allocates a new byte array and copies all the data in the hdos to it. > Then writeByteArray writes it all to "out". > We can do this instead: > if (out instanceof HeapDataOutputStream) { > out.writeAsSerializedByteArray(hdos); > } else { > .. do it the old way > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)