geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "xiaojian zhou (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (GEODE-2161) FilterRoutingInfo.FilterInfo.toData does unneeded copying
Date Thu, 01 Dec 2016 02:01:59 GMT

     [ https://issues.apache.org/jira/browse/GEODE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

xiaojian zhou reassigned GEODE-2161:
------------------------------------

    Assignee: xiaojian zhou

> FilterRoutingInfo.FilterInfo.toData does unneeded copying
> ---------------------------------------------------------
>
>                 Key: GEODE-2161
>                 URL: https://issues.apache.org/jira/browse/GEODE-2161
>             Project: Geode
>          Issue Type: Bug
>            Reporter: xiaojian zhou
>            Assignee: xiaojian zhou
>
> This is #52614
> FilterInfo.toData (that was being optimized for murex) does this:
>         // create a hdos
>         // write a bunch of stuff to it
>         byte[] myData = hdos.toByteArray();
>         DataSerializer.writeByteArray(myData, out);
> he toByteArray allocates a new byte array and copies all the data in the hdos to it.
> Then writeByteArray writes it all to "out".
> We can do this instead:
>   if (out instanceof HeapDataOutputStream) {
>     out.writeAsSerializedByteArray(hdos);
>   } else {
>     .. do it the old way
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message