Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Mon, 28 Nov 2016 17:21:58 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@geode.incubator.apache.org
Message-ID: <JIRA.13021636.1479429170000.379851.1480353718359@Atlassian.JIRA>
In-Reply-To: <JIRA.13021636.1479429170000@Atlassian.JIRA>
References: <JIRA.13021636.1479429170000@Atlassian.JIRA> <JIRA.13021636.1479429170323@arcas>
Subject: [jira] [Commented] (GEODE-2129) Need to generate pdx type id
 random(or avoid sequential)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 28 Nov 2016 17:22:03 -0000


    [ https://issues.apache.org/jira/browse/GEODE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702552#comment-15702552 ] 

ASF subversion and git services commented on GEODE-2129:
--------------------------------------------------------

Commit b04227117bbcc7d28473ad0e3743baa5e54bc022 in incubator-geode's branch refs/heads/develop from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b042271 ]

 GEODE-2129 Make pdxType id random.

Right now pdxtype id has 4 bytes. Out of those 4 bytes, one byte
reserved for distributed-system-id, this make sure type id generated
from different cluster has different id. For rest of the three bytes we
just increment counter to create new pdxtype id. In the field, we have
observed that sometimes this pdxType Id collides. One reason could be
they end up having same distributed-system-id for the different cluster.
Thus to avoid a collision, we will be using hashcode of pdxType for
three bytes of pdxType id. That will reduce the possibility of
collision.

Apart from that changed getOldValue call to region.get in
PeerTypeRegistration.

updated

updated

updated

update


> Need to generate pdx type id random(or avoid sequential)
> --------------------------------------------------------
>
>                 Key: GEODE-2129
>                 URL: https://issues.apache.org/jira/browse/GEODE-2129
>             Project: Geode
>          Issue Type: Bug
>          Components: serialization
>            Reporter: Hitesh Khamesra
>            Assignee: Hitesh Khamesra
>
> Right now pdxtype id has 4 bytes.  Out of those 4 bytes, one byte reserved for distributed-system-id, this make sure type id generated from different cluster has different id. For rest of the three bytes we just increment counter to create new pdxtype id.  In the field, we have observed that sometimes this pdxType Id collides.  One reason could be they end up having same distributed-system-id for the different cluster.  
> Thus to avoid a collision, we will be using hashcode of pdxType for three bytes of pdxType id. That will reduce the possibility of collision.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)