Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 29 Nov 2016 21:22:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.incubator.apache.org
Message-ID: <JIRA.12988463.1468277578000.393979.1480454578917@Atlassian.JIRA>
In-Reply-To: <JIRA.12988463.1468277578000@Atlassian.JIRA>
References: <JIRA.12988463.1468277578000@Atlassian.JIRA> <JIRA.12988463.1468277578418@arcas>
Subject: [jira] [Commented] (GEODE-1653) Executing a fire-and-forget
 function on all servers doesn't actually execute on all servers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 29 Nov 2016 21:23:07 -0000


    [ https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706567#comment-15706567 ] 

ASF GitHub Bot commented on GEODE-1653:
---------------------------------------

Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/293#discussion_r90116715
  
    --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java ---
    @@ -0,0 +1,164 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.geode.internal.cache;
    +
    +import org.apache.geode.cache.Region;
    +import org.apache.geode.cache.client.*;
    +import org.apache.geode.cache.client.internal.LocatorTestBase;
    +import org.apache.geode.cache.execute.Execution;
    +import org.apache.geode.cache.execute.Function;
    +import org.apache.geode.cache.execute.FunctionService;
    +import org.apache.geode.internal.AvailablePort;
    +import org.apache.geode.internal.cache.functions.TestFunction;
    +import org.apache.geode.test.dunit.Assert;
    +import org.apache.geode.test.dunit.Host;
    +import org.apache.geode.test.dunit.NetworkUtils;
    +import org.apache.geode.test.dunit.VM;
    +import org.apache.geode.test.junit.categories.DistributedTest;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +
    +import static com.jayway.awaitility.Awaitility.*;
    +import static java.util.concurrent.TimeUnit.*;
    +
    +/**
    + * Created by amey on 22/11/16.
    --- End diff --
    
    Minor nitpick, would you be able to remove the author tags?


> Executing a fire-and-forget function on all servers doesn't actually execute on all servers
> -------------------------------------------------------------------------------------------
>
>                 Key: GEODE-1653
>                 URL: https://issues.apache.org/jira/browse/GEODE-1653
>             Project: Geode
>          Issue Type: Bug
>          Components: functions
>            Reporter: Barry Oglesby
>            Assignee: Amey Barve
>
> Executing a fire-and-forget function on all servers only executes on the ones the client is currently connected to.
> The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute against using code like:
> {noformat}
> pool.getCurrentServers();
> {noformat}
> This method just gets all the {{EndpointManager's endpointMap's ServerLocations}}.
> What should be done is more like what the {{ExecuteFunctionOp execute}} methods do:
> {noformat}
> private static List<ServerLocation> getAllServers(PoolImpl pool) {
>   List<ServerLocation> servers = null;
>   if (pool.getLocators() == null || pool.getLocators().isEmpty()) {
>     servers = ((ExplicitConnectionSourceImpl) pool.getConnectionSource()).getAllServers();
>   } else {
>     servers = ((AutoConnectionSourceImpl) pool.getConnectionSource()).findAllServers(); // n/w call on locator
>   }
>   return servers;
> }
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)