geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2141) StatisticsMonitor and StatMonitorHandler should use ConcurrentHashSet to store monitors, listeners and statisticIds
Date Tue, 29 Nov 2016 15:06:58 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705530#comment-15705530
] 

ASF GitHub Bot commented on GEODE-2141:
---------------------------------------

Github user metatype commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/299#discussion_r90025277
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
    @@ -38,7 +37,8 @@
       private final boolean enableMonitorThread;
     
       /** The registered monitors */
    -  private volatile List<StatisticsMonitor> monitors = Collections.<StatisticsMonitor>emptyList();
    +  private volatile ConcurrentHashSet<StatisticsMonitor> monitors =
    --- End diff --
    
    Instead of `volatile` I think this should be final.  I don't see a write to this var after
initialization.


> StatisticsMonitor and StatMonitorHandler should use ConcurrentHashSet to store monitors,
listeners and statisticIds
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-2141
>                 URL: https://issues.apache.org/jira/browse/GEODE-2141
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Avinash Dongre
>            Assignee: Avinash Dongre
>
> In StatisticsMonitor and StatMonitorHandler List is used to store monitors, listeners
and statisticIds.
> We should be using ConcurrentHashSet for performance Reason.
> In my local testing  When I replace the List to com.gemstone.gemfire.internal.concurrent.
> ConcurrentHashSet
> I see significant improvement in creating large number of region creation.
> ( from ~7hrs to ~26 minutes)
> More details about the same is on dev list.
> Refer : http://markmail.org/message/o7td3fczylx4uaet



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message