geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2092) Security examples should not be in the product code
Date Fri, 18 Nov 2016 00:19:58 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675256#comment-15675256
] 

ASF GitHub Bot commented on GEODE-2092:
---------------------------------------

Github user kjduling commented on the issue:

    https://github.com/apache/incubator-geode/pull/288
  
    I moved the examples in to geode-examples/utils/src/main/java/org/apache/geode/example/security/
so it looks like I misunderstood and jumped the gun.  So, I'll undo that, and move them to
geode-core/src/main/java/org/apache/geode/examples/security/
    
    #2 should be correct.  No test should depend on any production code in geode-core.


> Security examples should not be in the product code
> ---------------------------------------------------
>
>                 Key: GEODE-2092
>                 URL: https://issues.apache.org/jira/browse/GEODE-2092
>             Project: Geode
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 1.0.0-incubating
>            Reporter: Kirk Lund
>            Assignee: Kevin Duling
>
> These three classes are currently in geode-core product package which implies they are
fully supported user API. They cannot be released in a user API package. They must be moved
to geode-examples:
> geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
> geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java
> geode-core/src/main/java/org/apache/geode/security/templates/SimpleSecurityManager.java
> If they need to be available within a jar, then geode-examples should be altered to build
a jar can be added to the classpath of a running application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message