geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1895) refactor code that does instanceof OffHeapRegionEntry
Date Wed, 09 Nov 2016 23:55:58 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652434#comment-15652434
] 

ASF subversion and git services commented on GEODE-1895:
--------------------------------------------------------

Commit 2f9ea5e8f22ba5fb9c4e9f39f5dae7c4863e0edc in incubator-geode's branch refs/heads/feature/GEODE-1895
from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2f9ea5e ]

Merge branch 'feature/GEODE-1785' into feature/GEODE-1895


> refactor code that does instanceof OffHeapRegionEntry
> -----------------------------------------------------
>
>                 Key: GEODE-1895
>                 URL: https://issues.apache.org/jira/browse/GEODE-1895
>             Project: Geode
>          Issue Type: Improvement
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>
> The code has about 10 places it does "instanceof OffHeapRegionEntry."
> It should be pretty easy to refactor these away.
> In most of these places we can just call a method on RegionEntry that does nothing (by
default), and then override that method on OffHeapRegionEntry to do the offheap work.
> Using "default" methods on interfaces (new in JDK 1.8) should make this easy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message