geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1122) Dependency on environment variable GEMFIRE needs to be removed
Date Sat, 19 Nov 2016 15:18:58 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679414#comment-15679414
] 

ASF GitHub Bot commented on GEODE-1122:
---------------------------------------

Github user metatype commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/291#discussion_r88781054
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java
---
    @@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion) {
        *        geode-web-api
        */
       public String findWarLocation(String warFilePrefix) {
    -    String gemfireHome = getGemFireHome();
    +    String gemfireHome = getGeodeHome();
    --- End diff --
    
    Can you update the above javadocs with GEODE_HOME instead of GEMFIRE?


> Dependency on environment variable GEMFIRE needs to be removed
> --------------------------------------------------------------
>
>                 Key: GEODE-1122
>                 URL: https://issues.apache.org/jira/browse/GEODE-1122
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Udo Kohlmeyer
>            Assignee: Avinash Dongre
>
> There is still a strong dependency on the environment variable GEMFIRE within GEODE.
This should be replaced with GEODE_HOME or removed completely from the system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message