Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4B495200BB5 for ; Sun, 2 Oct 2016 00:22:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A1AB160AE7; Sat, 1 Oct 2016 22:22:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 53F26160AEF for ; Sun, 2 Oct 2016 00:22:31 +0200 (CEST) Received: (qmail 11221 invoked by uid 500); 1 Oct 2016 22:22:30 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 11136 invoked by uid 99); 1 Oct 2016 22:22:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Oct 2016 22:22:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2B8ACC12C9 for ; Sat, 1 Oct 2016 22:22:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 7T-SR3s91U-W for ; Sat, 1 Oct 2016 22:22:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 9B4F960DA0 for ; Sat, 1 Oct 2016 22:22:26 +0000 (UTC) Received: (qmail 5970 invoked by uid 99); 1 Oct 2016 22:22:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Oct 2016 22:22:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 89E322C2AC0 for ; Sat, 1 Oct 2016 22:22:22 +0000 (UTC) Date: Sat, 1 Oct 2016 22:22:22 +0000 (UTC) From: "Swapnil Bawaskar (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GEODE-1742) Possible NPE from CqAttributesFactory.getCQListeners MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 01 Oct 2016 22:22:32 -0000 [ https://issues.apache.org/jira/browse/GEODE-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Bawaskar updated GEODE-1742: ------------------------------------ Fix Version/s: 1.0.0-incubating > Possible NPE from CqAttributesFactory.getCQListeners > ----------------------------------------------------- > > Key: GEODE-1742 > URL: https://issues.apache.org/jira/browse/GEODE-1742 > Project: Geode > Issue Type: Bug > Components: client queues > Reporter: Dan Smith > Assignee: Dan Smith > Fix For: 1.0.0-incubating > > > This method checks to see if cqListeners is null outside of synchronization. Other methods can set cqListeners to be null after this check but before cqListeners is used, resulting in an NPE > {code} > public CqListener[] getCqListeners() { > if (this.cqListeners == null){ > return CqAttributesImpl.EMPTY_LISTENERS; > } > > CqListener[] result = null; > synchronized(this.clSync){ > //Here, cqListeners may have been set to null by another method > result = new CqListener[cqListeners.size()]; > cqListeners.toArray(result); > } > return result; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)