Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56F87200B5A for ; Thu, 4 Aug 2016 19:04:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5564A160AAB; Thu, 4 Aug 2016 17:04:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9A27E160A6A for ; Thu, 4 Aug 2016 19:04:28 +0200 (CEST) Received: (qmail 34682 invoked by uid 500); 4 Aug 2016 17:04:27 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 34673 invoked by uid 99); 4 Aug 2016 17:04:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2016 17:04:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6BE551A7A9F for ; Thu, 4 Aug 2016 17:04:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ROKmFkQwTI3h for ; Thu, 4 Aug 2016 17:04:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 6F5895F1B8 for ; Thu, 4 Aug 2016 17:04:26 +0000 (UTC) Received: (qmail 31266 invoked by uid 99); 4 Aug 2016 17:04:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2016 17:04:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 98E9E2C0D60 for ; Thu, 4 Aug 2016 17:04:20 +0000 (UTC) Date: Thu, 4 Aug 2016 17:04:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1718) Region replace can return false when it should not and can fail with an NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 Aug 2016 17:04:29 -0000 [ https://issues.apache.org/jira/browse/GEODE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408132#comment-15408132 ] ASF subversion and git services commented on GEODE-1718: -------------------------------------------------------- Commit 91e234f85a6f8dfe1eedd59f6978e3667d0fd92a in incubator-geode's branch refs/heads/develop from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=91e234f ] GEODE-1718: fix replace on overflowed entry When replace checks the current value for equality with the expected value it now gets it from the EntryEventImpl which the replace operation had already called setOldValue on. Added a unit test that confirms that replace works on an overflowed entry and also handles INVALID values correctly. > Region replace can return false when it should not and can fail with an NPE > --------------------------------------------------------------------------- > > Key: GEODE-1718 > URL: https://issues.apache.org/jira/browse/GEODE-1718 > Project: Geode > Issue Type: Bug > Components: regions > Reporter: Darrel Schneider > Assignee: Darrel Schneider > > The Region replace method may return false when it should have returned true. The can happen on a region configured with overflow when the entry being replaced has overflowed to disk. It can also happen on a persistent region if the entry being replaced has not yet initialized its value from disk. > The NPE happens under the same configurations but when the expected old value was serialized with PDX and read-serialized was set to true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)