Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 18A98200B64 for ; Tue, 2 Aug 2016 20:07:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 17619160AA8; Tue, 2 Aug 2016 18:07:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5DD97160A65 for ; Tue, 2 Aug 2016 20:07:25 +0200 (CEST) Received: (qmail 62062 invoked by uid 500); 2 Aug 2016 18:07:24 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 62052 invoked by uid 99); 2 Aug 2016 18:07:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 18:07:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2FB76C0B66 for ; Tue, 2 Aug 2016 18:07:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 774sZbnjui1c for ; Tue, 2 Aug 2016 18:07:23 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 0FEDE5FAEE for ; Tue, 2 Aug 2016 18:07:21 +0000 (UTC) Received: (qmail 61634 invoked by uid 99); 2 Aug 2016 18:07:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 18:07:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B96022C0D65 for ; Tue, 2 Aug 2016 18:07:20 +0000 (UTC) Date: Tue, 2 Aug 2016 18:07:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Aug 2016 18:07:26 -0000 [ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404501#comment-15404501 ] ASF GitHub Bot commented on GEODE-1712: --------------------------------------- GitHub user gracemeilen opened a pull request: https://github.com/apache/incubator-geode/pull/223 GEODE-1712: introduce SecurityService and unit tests for security You can merge this pull request into a Git repository by running: $ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1712-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 ---- commit 70440b15fcebd1187e31c08da1142e56bea60b62 Author: gmeilen Date: 2016-07-18T20:13:11Z GEODE-1712: introduce SecurityService interface for mocking * create Unit Tests for client commands that use security commit d5d91fb3e9ddd54887724d63a3fa93551e1719dc Author: gmeilen Date: 2016-07-28T17:46:30Z GEODE-1713: cleanup imports commit 2b62775280fb5aff33c853278996884404d9392c Author: gmeilen Date: 2016-07-28T20:20:23Z GEODE-1712: add static factory methods to SecurityService commit 453f5e95dfdd62756f033a6b416999dcfb6db854 Author: gmeilen Date: 2016-08-01T20:16:25Z GEODE-1712: add missing categories and fix test failures ---- > Need unit tests for classes using Integrated Security > ----------------------------------------------------- > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests > Affects Versions: 1.0.0-incubating.M1 > Reporter: Grace Meilen > Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can be mocked so it's possible to write Unit Tests for all of the classes using Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)