geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1782) StatArchiveReader ignores later stats resource with same name as closed stats resource
Date Wed, 17 Aug 2016 23:46:20 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425611#comment-15425611
] 

ASF subversion and git services commented on GEODE-1782:
--------------------------------------------------------

Commit bac2e4eb6c12f9cca2a8ab7cffbf58bb380af19a in incubator-geode's branch refs/heads/feature/GEODE-1781-02
from [~apache@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=bac2e4e ]

GEODE-1782: include start timestamp in stat resource equals

* stat resources with different time stamps should not be equal

* StatArchiveWithConsecutiveResourceInstGenerator generates gfs with
multiple stat resources of same name but different times

* StatArchiveWithConsecutiveResourceInstIntegrationTest confirms
existence of bug GEODE-1782: StatArchiveReader ignores later stats
resource with same name as closed stats resource

* ResourceInstTest verifies the underlying issue and fix in
StatArchiveReader.ResourceInst.equals and the fix


> StatArchiveReader ignores later stats resource with same name as closed stats resource
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-1782
>                 URL: https://issues.apache.org/jira/browse/GEODE-1782
>             Project: Geode
>          Issue Type: Bug
>          Components: statistics
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>
> StatArchiveReader ignores later stats resource with same name as closed stats resource.

> The bug is caused by the current implementation of equals in the StatArchiveReader.ResourceInst
class. Each of the ResourceInst instances with the same name have different firstTSidx values.
The ResourceInst.equals implementation ignores firstTSidx, so StatArchiveReader determines
that the ResourceInst instances are equal and ignores the later instances.
> StatArchiveWithConsecutiveResourceInstIntegrationTest confirms the existence of the bug
and its fix.
> StatArchiveWithConsecutiveResourceInstGenerator generates a small gfs statistics file
containing the values needed to cause StatArchiveReader to hit the bug.
> ResourceInstTest is a new unit test for ResourceInst and confirms the changes for equals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message