geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1128) Add log messages and enhance the output of list-missing-disk-stores to report missing colocated regions
Date Thu, 18 Aug 2016 22:26:20 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427280#comment-15427280
] 

ASF GitHub Bot commented on GEODE-1128:
---------------------------------------

GitHub user pdxrunner opened a pull request:

    https://github.com/apache/incubator-geode/pull/234

    GEODE-1128: Fixes for colocation configuration problems

    1) Test parent regions on child region creates and throw IllegalStateException
    if parent region does not exist.
    Missing parent regions were not being checked for, which resulted in NPE's getting thrown.
    
    2) Log warnings when persistent colocated child regions don't exist.
    Persistent data recovery cannot complete for any region in a colocation hierarchy if there
are child regions that don't exist. The absence of any warning logs for this condition made
it difficult to diagnose configuration problems.
    
    3) Create Unit and DUnit tests for new exceptions and warnings

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1128

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit fd6b6b1c52f81977c990259853c2dd996f3a280d
Author: Ken Howe <khowe@pivotal.io>
Date:   2016-08-18T22:00:22Z

    GEODE-1128: Fixes for colocation configuration problems
    
    Test parent regions on child region creates and throw IllegalStateException
    if parent region does not exist
    
    Log warnings when persistent colocated child regions don't exist
    
    Create Unit and DUnit tests for new exceptions and warnings

----


> Add log messages and enhance the output of list-missing-disk-stores to report missing
colocated regions
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-1128
>                 URL: https://issues.apache.org/jira/browse/GEODE-1128
>             Project: Geode
>          Issue Type: Bug
>          Components: persistence
>            Reporter: Dan Smith
>            Assignee: Kenneth Howe
>
> Persistent recovery waits until all colocated regions are created. This is necessary
in order to maintain colocation. However, it can result in surprising behavior if a user doesn't
create a region or, in the case of GEODE-1117, geode doesn't create an internal region.
> We need a warning level log message indicating that some colocated regions are missing.
We do have a log message after 15 seconds if other members have not created persistent regions
- see the code in RedundancyLogger.logWaitingForMembers.
> We should enhance the logger to report any missing colocated regions as well.
> The list-missing-disk-stores command should also be enhanced to report missing colocated
regions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message