Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 223EC200B54 for ; Thu, 28 Jul 2016 19:40:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 20BAE160A85; Thu, 28 Jul 2016 17:40:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 67B87160A56 for ; Thu, 28 Jul 2016 19:40:24 +0200 (CEST) Received: (qmail 79244 invoked by uid 500); 28 Jul 2016 17:40:23 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 79235 invoked by uid 99); 28 Jul 2016 17:40:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2016 17:40:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3B6C41A05FC for ; Thu, 28 Jul 2016 17:40:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id W8fMMWeRcfik for ; Thu, 28 Jul 2016 17:40:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id BDB885F295 for ; Thu, 28 Jul 2016 17:40:21 +0000 (UTC) Received: (qmail 78872 invoked by uid 99); 28 Jul 2016 17:40:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2016 17:40:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A9CD32C0D69 for ; Thu, 28 Jul 2016 17:40:20 +0000 (UTC) Date: Thu, 28 Jul 2016 17:40:20 +0000 (UTC) From: "Grace Meilen (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (GEODE-1712) Need unit tests for classes using Integrated Security MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 28 Jul 2016 17:40:25 -0000 Grace Meilen created GEODE-1712: ----------------------------------- Summary: Need unit tests for classes using Integrated Security Key: GEODE-1712 URL: https://issues.apache.org/jira/browse/GEODE-1712 Project: Geode Issue Type: Test Components: tests Reporter: Grace Meilen Most of the classes using Integrated Security (GEODE-17) do not have Unit Tests (some have Integrated Test coverage). We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can be mocked so it's possible to write Unit Tests for all of the classes using Integrated Security. Client command classes that need Unit Tests: * CommitCommand * ContainsKey * ContainsKey66 * CreateRegion * Destroy65 * DestroyRegion * Destroy * ExecuteFunction65 * ExecuteFunction66 * ExecuteFunction * Get70 * GetAll70 * GetAll651 * GetAll * GetAllWithCallback * GetClientPartitionAttributesCommand66 * GetClientPartitionAttributesCommand * Invalidate * KeySet * Put61 * Put65 * Put * RegisterInterest61 * RegisterInterestList61 * RegisterInterestList66 * RegisterInterest * RemoveAll * Request * UnregisterInterest Non-core client command classes needing Unit Tests: * CloseCQ * ExecuteCQ * ExecuteCQ61 * GetCQStats * GetDurableCQs * MonitorCQ * StopCQ More classes needing Unit Tests: * AcceptorImpl * CacheClientProxy * HandShake * ServerConnection * CreateAllterDestroyRegionCommands * DataCommands * IndexCommands * DataCommandFunction * CommandProcessor * AccessControlMBean * MBeanServerWrapper * LoginHandlerInterceptor * LuceneIndexCommands * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)