Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.incubator.apache.org
Date: Wed, 20 Jul 2016 18:13:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.incubator.apache.org
Message-ID: <JIRA.12986229.1467389098000.85914.1469038400723@Atlassian.JIRA>
In-Reply-To: <JIRA.12986229.1467389098000@Atlassian.JIRA>
References: <JIRA.12986229.1467389098000@Atlassian.JIRA> <JIRA.12986229.1467389098495@arcas>
Subject: [jira] [Commented] (GEODE-1617) Regions can be created with a
 variety of characters that are unsupported
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 20 Jul 2016 18:13:28 -0000


    [ https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386341#comment-15386341 ] 

ASF GitHub Bot commented on GEODE-1617:
---------------------------------------

Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/201#discussion_r71577488
  
    --- Diff: geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java ---
    @@ -7769,17 +7879,55 @@ void cleanUpOnIncompleteOp(EntryEventImpl event, RegionEntry re) {
         this.entries.removeEntry(event.getKey(), re, false) ;      
       }
     
    -  static void validateRegionName(String name)
    +  static void validateRegionName(String name, InternalRegionArguments internalRegionArgs)
       {
         if (name == null) {
           throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_NULL.toLocalizedString());
         }
    -    if (name.length() == 0) {
    +    if (name.isEmpty()) {
           throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_BE_EMPTY.toLocalizedString());
         }
    -    if (name.indexOf(SEPARATOR) >= 0) {
    +    if (name.contains(SEPARATOR)) {
           throw new IllegalArgumentException(LocalizedStrings.LocalRegion_NAME_CANNOT_CONTAIN_THE_SEPARATOR_0.toLocalizedString(SEPARATOR));
         }
    +
    +    // Validate the name of the region only if it isn't an internal region
    +    if (internalRegionArgs.isInternalRegion()){
    +      return;
    +    }
    +    if (internalRegionArgs.isUsedForMetaRegion()) {
    +      return;
    +    }
    +    if (internalRegionArgs.isUsedForPartitionedRegionAdmin()) {
    +      return;
    +    }
    +    if (internalRegionArgs.isUsedForPartitionedRegionBucket()) {
    +      return;
    +    }
    +
    +//    LocalRegion metaRegion = internalRegionArgs.getInternalMetaRegion();
    +//    if (metaRegion != null) {
    +//      if (metaRegion instanceof HARegion) {
    +//        if (metaRegion.getName().equals(name)) {
    +//          return;
    +//        }
    +//      }
    +//      if (metaRegion instanceof SerialGatewaySenderQueueMetaRegion) {
    +//        return;
    +//      }
    +//    }
    +
    +    if (name.startsWith("__")
    --- End diff --
    
    Why was the special case needed? Shouldn't this region have set isInternalRegion?


> Regions can be created with a variety of characters that are unsupported
> ------------------------------------------------------------------------
>
>                 Key: GEODE-1617
>                 URL: https://issues.apache.org/jira/browse/GEODE-1617
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>    Affects Versions: 1.0.0-incubating.M2
>            Reporter: Kevin Duling
>            Assignee: Kevin Duling
>
> Per this [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html], and this [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html] on the dev forums and [geode documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html], region names may only consist of alphanumeric characters, an underscore, and a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while others cannot be located.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)