Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.incubator.apache.org
Date: Wed, 13 Jul 2016 20:03:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.incubator.apache.org
Message-ID: <JIRA.12986229.1467389098000.19906.1468440200534@Atlassian.JIRA>
In-Reply-To: <JIRA.12986229.1467389098000@Atlassian.JIRA>
References: <JIRA.12986229.1467389098000@Atlassian.JIRA> <JIRA.12986229.1467389098495@arcas>
Subject: [jira] [Commented] (GEODE-1617) Regions can be created with a
 variety of characters that are unsupported
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 13 Jul 2016 20:03:25 -0000


    [ https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375640#comment-15375640 ] 

ASF GitHub Bot commented on GEODE-1617:
---------------------------------------

GitHub user kjduling opened a pull request:

    https://github.com/apache/incubator-geode/pull/201

    GEODE-1617: Regions can be created with a variety of characters that are unsupported

    Updated the pull request for this ticket after several unit tests failed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1617

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #201
    
----
commit 0701dbf2f10e7c97e76b9f3a9dbdd4c027ec4de0
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-07-11T21:20:56Z

    GEODE-1617: Regions can be created with a variety of characters that are unsupported
    
    Test for valid characters when creating non-internal regions

commit 7d7d2f33073cc73be79edf121bb3aba231494421
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-07-12T22:16:31Z

    GEODE-1617: Regions can be created with a variety of characters that are unsupported
    
    Updated unit tests and added a new isInternalRegion field to InternalRegionAttributes

commit 0a8d5ba739aaafb30bbc16452d67e9d31a32c6d6
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-07-12T22:17:10Z

    Merge branch 'develop' of github.com:apache/incubator-geode into feature/GEODE-1617

commit 7e229b5ece5a87068858f07ea0ace8a1859d9f7c
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-07-13T19:57:15Z

    GEODE-748: Regions can be created with a variety of characters that are unsupported
    
    Fixed issue with HA region.

----


> Regions can be created with a variety of characters that are unsupported
> ------------------------------------------------------------------------
>
>                 Key: GEODE-1617
>                 URL: https://issues.apache.org/jira/browse/GEODE-1617
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>    Affects Versions: 1.0.0-incubating.M2
>            Reporter: Kevin Duling
>            Assignee: Kevin Duling
>
> Per this [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html], and this [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html] on the dev forums and [geode documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html], region names may only consist of alphanumeric characters, an underscore, and a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while others cannot be located.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)