Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BBF4E200B3B for ; Mon, 11 Jul 2016 19:42:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BA7DC160A78; Mon, 11 Jul 2016 17:42:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 10713160A5E for ; Mon, 11 Jul 2016 19:42:22 +0200 (CEST) Received: (qmail 36804 invoked by uid 500); 11 Jul 2016 17:42:17 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 36795 invoked by uid 99); 11 Jul 2016 17:42:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2016 17:42:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DCABB1A543A for ; Mon, 11 Jul 2016 17:42:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id L80STeKgez_p for ; Mon, 11 Jul 2016 17:42:13 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 69F795F484 for ; Mon, 11 Jul 2016 17:42:12 +0000 (UTC) Received: (qmail 35758 invoked by uid 99); 11 Jul 2016 17:42:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2016 17:42:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 68A5B2C02B0 for ; Mon, 11 Jul 2016 17:42:11 +0000 (UTC) Date: Mon, 11 Jul 2016 17:42:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1452) Annotate disabled test methods with @Ignore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Jul 2016 17:42:23 -0000 [ https://issues.apache.org/jira/browse/GEODE-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371260#comment-15371260 ] ASF GitHub Bot commented on GEODE-1452: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/184 > Annotate disabled test methods with @Ignore > ------------------------------------------- > > Key: GEODE-1452 > URL: https://issues.apache.org/jira/browse/GEODE-1452 > Project: Geode > Issue Type: Test > Components: tests > Reporter: Kirk Lund > Assignee: Kirk Lund > > Some of the older tests have test methods which were disabled by renaming the test method from JUnit 3 syntax to something like "public void _testMethod" or "public void disabled_testMethod". > Most of these tests were then updated to JUnit 4, but the disabled tests remain without @Ignore or @Test annotations. > We should annotate these test methods with @Ignore and @Test so they are correctly counted as skipped tests. Tickets should then be filed to analyze whether these tests should be fixed or deleted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)