geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1642) Add conveniance method isCancelInProgress to CancelCriterion
Date Tue, 12 Jul 2016 23:44:20 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373970#comment-15373970
] 

ASF subversion and git services commented on GEODE-1642:
--------------------------------------------------------

Commit 435283357a59dcfe25fad9126e7b5a6433fd20d1 in incubator-geode's branch refs/heads/develop
from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4352833 ]

GEODE-1642 Add conveniance method isCancelInProgress to CancelCriterion

This adds a new method, isCancelInProgress(), to CancelCriterion.  Most
uses of the method cancelInProgress() have now been changed to use the
new method.

This also includes a fix for GEODE-1596, an IndexOutOfBoundsException
suspect string in JGroups.


> Add conveniance method isCancelInProgress to CancelCriterion
> ------------------------------------------------------------
>
>                 Key: GEODE-1642
>                 URL: https://issues.apache.org/jira/browse/GEODE-1642
>             Project: Geode
>          Issue Type: Bug
>          Components: general
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>
> Geode's code has a lot of cancellation checks that look like this:
> if (cache.getCancelCriterion().cancelInProgress() != null)
> It seems very odd to have to perform a null check to see if the cache is shutting down.
 CancelCriterion should have a isCancelInProgress() method that can be used instead of the
null check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message