geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1598) gfsh auto-complete removes previously typed options
Date Mon, 11 Jul 2016 20:55:11 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371593#comment-15371593
] 

ASF GitHub Bot commented on GEODE-1598:
---------------------------------------

GitHub user gracemeilen opened a pull request:

    https://github.com/apache/incubator-geode/pull/195

    GEODE-1598: fix auto-completion problems

    
    
    Spring shell, jopt-simple and Geode GFSH code all duplicated the concept of required options.
jopt-simple can be blind to this, which prevents OptionParser.parse from throwing an Exception
when a required option is missing at time of hitting tab for auto-complete. This allows OptionParser
to return an OptionSet containing all detected options which is necessary for auto-completion
to behave correctly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1598-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit a81d5cb6130c7bdf94851975069056e151e8daf9
Author: gmeilen <gracemeilen@gmail.com>
Date:   2016-07-11T20:45:39Z

    GEODE-1598: fix auto-completion problems by telling jopt that all options are optional
    
    Spring shell, jopt-simple and Geode GFSH code all duplicated the concept of required options.
jopt-simple can be blind to this, which prevents OptionParser.parse from throwing an Exception
when a required option is missing at time of hitting tab for auto-complete. This allows OptionParser
to return an OptionSet containing all detected options which is necessary for auto-completion
to behave correctly.

----


> gfsh auto-complete removes previously typed options
> ---------------------------------------------------
>
>                 Key: GEODE-1598
>                 URL: https://issues.apache.org/jira/browse/GEODE-1598
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>    Affects Versions: 1.0.0-incubating.M3
>            Reporter: Swapnil Bawaskar
>            Assignee: Grace Meilen
>
> This may also be related to fixing GEODE-835.
> When one starts typing in a gfsh command like:
> {noformat}
> gfsh>start server --name=serv1 --se
> {noformat}
> and then hit {{tab}} for autocompletion, the previously completed --name option disappears
and all I am left with is:
> {noformat}
> gfsh>start server --se
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message