geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-11) Lucene Integration
Date Tue, 26 Jul 2016 17:37:21 GMT


ASF GitHub Bot commented on GEODE-11:

Github user upthewaterspout commented on the issue:
    This change is mixing internal classes in the public API. You're adding getDefinedIndexes
to the public API, but it returns LuceneIndexCreationProfile objects which is an internal
class. Looking at LuceneIndexCreationProfile, I think these methods probably don't belong
on LuceneService. Maybe put these methods on InternalLuceneService?
    I think setFieldAnalyzerStrings is not a good name, because it's not actually setting
anything on the object. Same with setFieldAnalyzerStringsFromProfile.
    The boolean "status" field in in LuceneIndexDetails is confusing - what does true or false
mean? Maybe it should be named initialized?

> Lucene Integration
> ------------------
>                 Key: GEODE-11
>                 URL:
>             Project: Geode
>          Issue Type: New Feature
>          Components: querying
>            Reporter: Dan Smith
>            Assignee: xiaojian zhou
> This is a feature that has been under development for GemFire but was not part of the
initial drop of code for geode.
> Allow Lucene indexes to be stored in Geode regions allowing users to do text searches
on data stored in Geode. 

This message was sent by Atlassian JIRA

View raw message