geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1521) APP_FETCH_SIZE in GFSH should not be applied to COUNT queries
Date Fri, 10 Jun 2016 17:07:20 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324830#comment-15324830
] 

ASF GitHub Bot commented on GEODE-1521:
---------------------------------------

GitHub user kjduling opened a pull request:

    https://github.com/apache/incubator-geode/pull/155

    GEODE-1521 - APP_FETCH_SIZE in GFSH should not be applied to COUNT qu…

    …eries
    
    Change to search for " count(" instead of "count(*)" because 'count' can accept more options
than simply a star.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1521

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 81015586abccec345caf156e2e04a685c25eadcd
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-06-10T17:03:44Z

    GEODE-1521 - APP_FETCH_SIZE in GFSH should not be applied to COUNT queries
    
    Change to search for " count(" instead of "count(*)" because 'count' can accept more options
than simply a star.

----


> APP_FETCH_SIZE in GFSH should not be applied to COUNT queries
> -------------------------------------------------------------
>
>                 Key: GEODE-1521
>                 URL: https://issues.apache.org/jira/browse/GEODE-1521
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Kevin Duling
>            Assignee: Kevin Duling
>
> There are more varieties of count than simply * within the count().  Specifically, one
can do:  {{count(distinct(field))}} or {{count(field)}}
> This makes checking for only {{count( * )}} incorrect.  Instead, the search to apply
the limt should look for {{" count("}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message