geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
Date Fri, 17 Jun 2016 18:13:05 GMT

    [ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336605#comment-15336605
] 

ASF GitHub Bot commented on GEODE-117:
--------------------------------------

GitHub user kjduling opened a pull request:

    https://github.com/apache/incubator-geode/pull/166

    GEODE-117 - gfsh put ignores --skip-if-exists flag

    Fixed test, which erroneously reported that the --skip-if-exists flag is honored.
    Implemented check for flag within the put operation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-117

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #166
    
----
commit 5793770e559e054a5639f2f56ddcf07424e4c1ad
Author: Kevin J. Duling <kduling@pivotal.io>
Date:   2016-06-17T18:07:49Z

    GEODE-117 - gfsh put ignores --skip-if-exists flag
    
    Fixed test, which erroneously reported that the --skip-if-exists flag is honored.
    Implemented check for flag within the put operation.

----


> gfsh put ignores --skip-if-exists flag
> --------------------------------------
>
>                 Key: GEODE-117
>                 URL: https://issues.apache.org/jira/browse/GEODE-117
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Dan Smith
>            Assignee: Kevin Duling
>              Labels: gfsh, starter
>             Fix For: 1.0.0-incubating.M3
>
>
> Someone hit this on a forum post:
> https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21
> I looked into the code, and it looks like the flag gets lost somewhere along the way.
If you look at DataCommandFunction.put, it has a putIfAbsent flag, but that flag is not used;
the function just does a normal put.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message