Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 636FC2009F3 for ; Fri, 6 May 2016 00:57:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6228F160A05; Thu, 5 May 2016 22:57:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A9798160A04 for ; Fri, 6 May 2016 00:57:16 +0200 (CEST) Received: (qmail 4427 invoked by uid 500); 5 May 2016 22:57:15 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 4301 invoked by uid 99); 5 May 2016 22:57:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2016 22:57:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 742CBC0176 for ; Thu, 5 May 2016 22:57:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id HHnOGDnQKAvz for ; Thu, 5 May 2016 22:57:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id C41515F487 for ; Thu, 5 May 2016 22:57:13 +0000 (UTC) Received: (qmail 4266 invoked by uid 99); 5 May 2016 22:57:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 May 2016 22:57:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D8DA52C1F5C for ; Thu, 5 May 2016 22:57:12 +0000 (UTC) Date: Thu, 5 May 2016 22:57:12 +0000 (UTC) From: "Darrel Schneider (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (GEODE-1356) DataAsAddress should not be used in comments and strings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 05 May 2016 22:57:17 -0000 Darrel Schneider created GEODE-1356: --------------------------------------- Summary: DataAsAddress should not be used in comments and strings Key: GEODE-1356 URL: https://issues.apache.org/jira/browse/GEODE-1356 Project: Geode Issue Type: Bug Components: offheap Reporter: Darrel Schneider The offheap implementation used to have a class named DataAsAddress. It no longer does. But we still have some places in the code that use this name. For example: UnsupportedOperationException("Did not expect DataAsAddress to be compressed"); should be changed to: UnsupportedOperationException("Did not expect encoded address to be compressed"); Another: // else it is DataAsAddress. This code just returns it as prepared. should be: // else it is has no refCount so just return it as prepared. Also the method: getSerializedLengthFromDataAsAddress should be renamed (or removed since it is deadcode). -- This message was sent by Atlassian JIRA (v6.3.4#6332)