Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6FF552009D9 for ; Mon, 2 May 2016 23:36:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6E8D81609B0; Mon, 2 May 2016 23:36:17 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4D2F1602C5 for ; Mon, 2 May 2016 23:36:16 +0200 (CEST) Received: (qmail 26728 invoked by uid 500); 2 May 2016 21:36:15 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 26719 invoked by uid 99); 2 May 2016 21:36:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 21:36:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 672F7C0183 for ; Mon, 2 May 2016 21:36:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ODswXc_SF_Of for ; Mon, 2 May 2016 21:36:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id AB0655F255 for ; Mon, 2 May 2016 21:36:13 +0000 (UTC) Received: (qmail 26643 invoked by uid 99); 2 May 2016 21:36:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 21:36:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D0E6A2C0451 for ; Mon, 2 May 2016 21:36:12 +0000 (UTC) Date: Mon, 2 May 2016 21:36:12 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1329) auto-reconnect attempts cease if kicked out during boot-up of the cache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 May 2016 21:36:17 -0000 [ https://issues.apache.org/jira/browse/GEODE-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267548#comment-15267548 ] ASF subversion and git services commented on GEODE-1329: -------------------------------------------------------- Commit b893abe094b2df73e51cdce1d0716fc984b1115c in incubator-geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b893abe ] GEODE-1329 auto-reconnect attempts cease if kicked out during boot-up of the cache InternalDistributedSystem.reconnect() now includes cache-creation in its retry loop and, should the cache fail to start due to a CancelException it will shut down and try again. While creating a new test in ReconnectDUnitTest I found problems with the other tests in that class that I fixed. Notably the method getDistributedSystemProperties() wasn't returning the correct properties for a lot of test cases because the dsProperties variable wasn't being set by them and they were using the getCache() method. This was causing the current distributed system to be destroyed and a new one created with different properties than the test wanted. That was causing periodic test failures. > auto-reconnect attempts cease if kicked out during boot-up of the cache > ----------------------------------------------------------------------- > > Key: GEODE-1329 > URL: https://issues.apache.org/jira/browse/GEODE-1329 > Project: Geode > Issue Type: Bug > Components: membership > Reporter: Bruce Schuchardt > Assignee: Bruce Schuchardt > > If a server has been kicked out of the distributed system and is able to reconnect it may cease efforts to rejoin the system if it is kicked out after joining the system but before its cache is completely rebuilt. > The code in InternalDistributedSystem.reconnect() has a {{while}} loop that exits after the new DistributedSystem has been created and then the method goes on to rebuild the Cache. If there is a problem rebuilding the cache it does not retry, but it should. -- This message was sent by Atlassian JIRA (v6.3.4#6332)