geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-1378) checkMissedTests launches dunit VMs, takes time
Date Wed, 18 May 2016 18:39:12 GMT


ASF subversion and git services commented on GEODE-1378:

Commit 18761c729396936e1f05dcfd69f344f5762dedb7 in incubator-geode's branch refs/heads/develop
from [~upthewaterspout]
[;h=18761c7 ]

GEODE-1378: Don't launch dunit VMs in checkMissedTests

Setting a system property to disable launching dunit VMs during

DistributedLockServiceDUnitTest failed with this property set because it
was doing work in the constructor. I cleaned up the test to create the
blackboard in the set up method instead.

> checkMissedTests launches dunit VMs, takes time
> -----------------------------------------------
>                 Key: GEODE-1378
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: build, tests
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.0.0-incubating.M3
> The checkMissedTests target actually triggers the launch of dunit VMs, even though no
tests are run (normally).
> I think this has to do with how the dunit framework is written and how we are using categories.
> For junit 4 tests, we are launching the dunit framework from a BeforeClass in JUnit4DistributedTest
method. For unit 3 tests, we launch the dunit framework from with the constructor of Junt3DistributedTests.
> I think junit is calling one of these things (probably the junit 3 contructor) when it
is determining the categories of the tests. That's causing the checkMissedTests target to
launch all of the dunit VMs even though it doesn't run the tests.

This message was sent by Atlassian JIRA

View raw message