geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1296) OffHeapStoredObject.getRawBytes should assert that it is not called on compressed data
Date Thu, 19 May 2016 18:29:12 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291881#comment-15291881
] 

ASF GitHub Bot commented on GEODE-1296:
---------------------------------------

Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/145#discussion_r63930600
  
    --- Diff: geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java
---
    @@ -42,6 +42,10 @@
     @Category(UnitTest.class)
     public class OffHeapStoredObjectJUnitTest extends AbstractStoredObjectTestBase {
     
    +  static {
    --- End diff --
    
    Remove this static block. I talked with Kirk and we think that java assertions are enabled
consistently from both gradle and the IDE


> OffHeapStoredObject.getRawBytes should assert that it is not called on compressed data
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-1296
>                 URL: https://issues.apache.org/jira/browse/GEODE-1296
>             Project: Geode
>          Issue Type: Bug
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Kenneth Howe
>
> The current code does this:
>       if (isCompressed()) {
>         throw new UnsupportedOperationException();
>       }
> It would be more clear if it just did this:
>       assert !isCompressed();



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message