geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1282) missing release of GatewaySenderEventImpl when it is removed from tempQueue
Date Tue, 24 May 2016 18:54:13 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298702#comment-15298702
] 

ASF subversion and git services commented on GEODE-1282:
--------------------------------------------------------

Commit 463ae16a7c0b762abdf33d2aad1002721cccb53a in incubator-geode's branch refs/heads/feature/GEODE-1153
from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=463ae16 ]

GEODE-1282: fix wan off-heap leak

destroyFromTempQueue now releases GatewaySenderEventImpl when it is removed from the tempQueue


> missing release of GatewaySenderEventImpl when it is removed from tempQueue
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-1282
>                 URL: https://issues.apache.org/jira/browse/GEODE-1282
>             Project: Geode
>          Issue Type: Bug
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>             Fix For: 1.0.0-incubating.M3
>
>
> This code might be the cause of off-heap orphans in gateway tests:
> com.gemstone.gemfire.internal.cache.wan.parallel.ParallelQueueRemovalMessage.destroyFromTempQueue(PartitionedRegion,
int, Object)
>       BlockingQueue<GatewaySenderEventImpl> tempQueue = prq
>     		  .getBucketTmpQueue(bId);
>       if (tempQueue != null) {
>         Iterator<GatewaySenderEventImpl> itr = tempQueue.iterator();
>         while (itr.hasNext()) {
>           GatewaySenderEventImpl eventForFilter = itr.next();
>           //fix for #48082
>           afterAckForSecondary_EventInTempQueue(qPR.getParallelGatewaySender(), eventForFilter);
>           if (eventForFilter.getShadowKey().equals(key)) {
>             itr.remove();
>             isDestroyed = true;
>           }
>         }
>       }
> The bug is when it does "itr.remove();". It needs to also do "eventForFilter.release();".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message