Return-Path: X-Original-To: apmail-geode-issues-archive@minotaur.apache.org Delivered-To: apmail-geode-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DFAD199C9 for ; Fri, 22 Apr 2016 00:14:15 +0000 (UTC) Received: (qmail 27700 invoked by uid 500); 22 Apr 2016 00:14:15 -0000 Delivered-To: apmail-geode-issues-archive@geode.apache.org Received: (qmail 27667 invoked by uid 500); 22 Apr 2016 00:14:15 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 27658 invoked by uid 99); 22 Apr 2016 00:14:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 00:14:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D3C0C1A0136 for ; Fri, 22 Apr 2016 00:14:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id A8z8d3I-xc7l for ; Fri, 22 Apr 2016 00:14:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id C6B105F2F2 for ; Fri, 22 Apr 2016 00:14:13 +0000 (UTC) Received: (qmail 27277 invoked by uid 99); 22 Apr 2016 00:14:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 00:14:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EE11A2C1F68 for ; Fri, 22 Apr 2016 00:14:12 +0000 (UTC) Date: Fri, 22 Apr 2016 00:14:12 +0000 (UTC) From: "Darrel Schneider (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (GEODE-1273) IndexManager.populateIndexes does extra work for off-heap and compression MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Darrel Schneider created GEODE-1273: --------------------------------------- Summary: IndexManager.populateIndexes does extra work for off-heap and compression Key: GEODE-1273 URL: https://issues.apache.org/jira/browse/GEODE-1273 Project: Geode Issue Type: Bug Components: offheap Reporter: Darrel Schneider IndexManager.populateIndexes call entry.getValue on every entry in a region. It does this to make sure that entry is faulted in from disk before adding the region to multiple indexes. Here is the reason it gives for doing this: // Fault in the value once before index update so that every index // update does not have to read the value from disk every time. But if the region is offheap then calling getValue does fault it in but also copies it to the heap as a VMCachedDeserializable or byte array. But this code never uses the result of getValue (it is just called for the side effect of faulting it in). In the case of a compressed region getValue also has to decompress the value and deserialize it. So the code does a bunch of work for offheap and compression that is not needed. Instead of calling RegionEntry.getValue we need a call on RegionEntry that just does the fault in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)