Return-Path: X-Original-To: apmail-geode-issues-archive@minotaur.apache.org Delivered-To: apmail-geode-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C35319E53 for ; Fri, 8 Apr 2016 16:27:28 +0000 (UTC) Received: (qmail 12500 invoked by uid 500); 8 Apr 2016 16:27:28 -0000 Delivered-To: apmail-geode-issues-archive@geode.apache.org Received: (qmail 12472 invoked by uid 500); 8 Apr 2016 16:27:27 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 12458 invoked by uid 99); 8 Apr 2016 16:27:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 16:27:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 66443C021C for ; Fri, 8 Apr 2016 16:27:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3zJwWU6cl1Vc for ; Fri, 8 Apr 2016 16:27:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 2EC525F1BE for ; Fri, 8 Apr 2016 16:27:26 +0000 (UTC) Received: (qmail 12141 invoked by uid 99); 8 Apr 2016 16:27:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 16:27:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 900EB2C1F4E for ; Fri, 8 Apr 2016 16:27:25 +0000 (UTC) Date: Fri, 8 Apr 2016 16:27:25 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-1177) Session replication local cache is reporting bad object sizes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232434#comment-15232434 ] ASF subversion and git services commented on GEODE-1177: -------------------------------------------------------- Commit e0c20de1645d65bd67eb61350c2ad474b341998c in incubator-geode's branch refs/heads/feature/GEODE-17-2 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=e0c20de ] GEODE-1177: Adding a few more classes to exclude from object sizing This is not a complete fix for the http session management problem, but this is a safety catch we should probably have in the product to avoid following references into InternalDistributedSystem, Classloaders, or Loggers when computing the size of a user's object. > Session replication local cache is reporting bad object sizes > ------------------------------------------------------------- > > Key: GEODE-1177 > URL: https://issues.apache.org/jira/browse/GEODE-1177 > Project: Geode > Issue Type: Bug > Components: http session > Reporter: Dan Smith > > The session replication module has a local cache that uses heap LRU - See PeerToPeerSessionCache.createOrRetrieveLocalRegion. > When using LRU, the region uses an object sizer to determine the size of the objects. The default object sizer finds all reachable objects using reflection for the first value in the region, and then reuses that size for all subsequent values of the same class. See EvictionAction.createLRUHeapAttributes(). > In the case of session replication, it looks like we put a GemfireHttpSession in the region. Unfortunately, that has references back to the session manager, which has references to an InternalDistributedSystem, which in turn pulls in a whole lot of junk. > So the size of the objects reported by the sizer for this local cache are probably completely wrong, which might affect the behavior of the heap LRU. -- This message was sent by Atlassian JIRA (v6.3.4#6332)