geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1059) QueryREUpdateInProgressJUnitTest needs should not instantiate PRQueryHelper
Date Thu, 28 Apr 2016 14:52:13 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262264#comment-15262264
] 

ASF subversion and git services commented on GEODE-1059:
--------------------------------------------------------

Commit 6fb84d96294e50f3f4d1914a66d82dd1da4dceff in incubator-geode's branch refs/heads/feature/GEODE-17-2
from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6fb84d9 ]

GEODE-1059: PRQueryDUnitHelper no longer inherits PartitionedRegionDUnitTestCase class

* PRQueryDUnitHelper class no longer inherits PartitionedRegionDUnitTestCase hence no more
calls to its constructor.
* All the methods for creating PortfolioData elements were moved to Utils class.
* Removed the file PRQueryPerfDUnitTest.java

This closes #132


> QueryREUpdateInProgressJUnitTest needs should not instantiate PRQueryHelper
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-1059
>                 URL: https://issues.apache.org/jira/browse/GEODE-1059
>             Project: Geode
>          Issue Type: Improvement
>          Components: querying
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>              Labels: CI, Flaky
>
> Currently tests in this class are using PRQueryHelper.  PRQueryHelper itself is a DUnit
test, this ends up creating the dunit vms even though the original test does not require these
vms.
> Instead the helper code that is being used (in this case, creation of Portfolio objects)
can be copied/moved over to the JUnit test itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message