geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-1025) Remove compile dependency on spring data gemfire/geode
Date Mon, 11 Apr 2016 15:14:25 GMT

    [ https://issues.apache.org/jira/browse/GEODE-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235250#comment-15235250
] 

ASF subversion and git services commented on GEODE-1025:
--------------------------------------------------------

Commit 26225108623fefc6a03fec346d2fb157420b0d24 in incubator-geode's branch refs/heads/feature/GEODE-17-2
from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2622510 ]

GEODE-1025: Force the version of spring core we use

Spring shell depends on an old version of spring-core. Once all of the
rest of the spring dependencies were removed from geode-core, the spring
shell dependency won and caused us to bundle the older version of spring
core in the lib directory.

With this change, we all always use the desired version of spring-core.


> Remove compile dependency on spring data gemfire/geode
> ------------------------------------------------------
>
>                 Key: GEODE-1025
>                 URL: https://issues.apache.org/jira/browse/GEODE-1025
>             Project: Geode
>          Issue Type: Improvement
>          Components: build
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.0.0-incubating.M2
>
>
> We have a compile dependency on spring data gemfire in the ServerLauncher class to support
launching a server using a spring data gemfire configuration instead of a cache.xml file.
> That's a good feature to have, but it should be part of spring data gemfire, not geode.
Because of this compile dependency on SDG, we currently have a circular dependency on SDG
-> Geode -> SDG. That makes it difficult to do things like rename packages in geode
(GEODE-37) because SDG is still using the old packages.
> Instead of directly depending on spring data gemfire, we should provide an extension
point that SDG can plug into to override the cache server startup behavior.
> The easiest place way to do this is just to use the java ServiceLoader mechanism. We
can provide an interface for a plugin that replaces startup behavior of the server. SDG can
provide an implementation of this interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message