geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-247) LocalDataSet executeQuery method ignores the parameter buckets
Date Tue, 22 Mar 2016 17:52:25 GMT


ASF subversion and git services commented on GEODE-247:

Commit 0b7ae43874ec5ee82e36f0334d8c3fd6212e0e8e in incubator-geode's branch refs/heads/develop
from [~nnag]
[;h=0b7ae43 ]

GEODE-247: Fix in executeQuery function to use the bucket parameter and added tests cases
for it.

* modification of the function executeQuery to use the parameter bucket rather than ignoring
* added integration test QueryWithBucketParameterIntegrationTest which tests variations in
the  bucket parameter.
* code improvements done as per the review comments in github pull request
* placed MyValue, createAndPopulateSet and populateRegion into a separate file
as being reused by two test cases to avoid redundant code
* modified BugJUnitTest to import the TestData package and replaced for loops with IntStreams
and lambda functions.

NOTE: This is an internal API which needs to be deprecated and replaced with an API without
the bucket parameter.

This closes #117

> LocalDataSet executeQuery method ignores the parameter buckets
> --------------------------------------------------------------
>                 Key: GEODE-247
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>            Priority: Minor
> The buckets passes in as a parameter into this call are completely ignored.  It should
probably be used instead of the getBucketSet().
>  public Object executeQuery(DefaultQuery query, Object[] parameters,
>       Set buckets) throws FunctionDomainException,
>       TypeMismatchException, NameResolutionException,
>       QueryInvocationTargetException {
> ...
>  result = this.proxy.executeQuery(query, parameters, getBucketSet());
> ...

This message was sent by Atlassian JIRA

View raw message