geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Smith (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-27) Apache Geode POM file(s) are incorrect!
Date Fri, 18 Mar 2016 20:54:33 GMT

    [ https://issues.apache.org/jira/browse/GEODE-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202147#comment-15202147
] 

Dan Smith commented on GEODE-27:
--------------------------------

I believe with this recent set of changes, this bug is now addressed. There is
1) Only 1 repository
2) Optional jars are marked optional
3) Transitive dependencies are listed in the pom.

I've attached the latest geode-core pom file after my changes if anyone wants to review it
without running their own gradle install.

There is still a lot more cleanup needed to winnow the list of optional dependencies by moving
code out of geode-core into submodules. Most of that work has been added as subtasks to GEODE-818.

> Apache Geode POM file(s) are incorrect!
> ---------------------------------------
>
>                 Key: GEODE-27
>                 URL: https://issues.apache.org/jira/browse/GEODE-27
>             Project: Geode
>          Issue Type: Bug
>          Components: build, general
>    Affects Versions: 1.0.0-incubating
>         Environment: Apache Geode in Maven or Gradle-based applications.
>            Reporter: John Blum
>            Assignee: Mark Bretl
>            Priority: Critical
>              Labels: ApacheGeode, Maven, POM
>             Fix For: 1.0.0-incubating.M2
>
>         Attachments: gemfire-8.2.0.pom, gemfire-core-1.0.0-incubating-SNAPSHOT.pom, gemfire-jgroups-1.0.0-incubating-SNAPSHOT.pom,
gemfire-joptsimple-1.0.0-incubating-SNAPSHOT.pom, gemfire-json-1.0.0-incubating-SNAPSHOT.pom
>
>
> This JIRA is a followup to [GEODE-23] to note the additional issues that are considered
["out-of-scope"|http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201505.mbox/ajax/%3CCA%2BULb%2Btfm4LyjwMaB_B7j8WaBNoAYj1%2BkeZSW-pqv0Gdbq2T8g%40mail.gmail.com%3E]
for [GEODE-23], yet need to be fixed, none-the-less.
> Specifically, the changes include...
> 1. The {{<repositories>}} declarations need to be cleaned up (reduced).  Technically,
_Apache Geode_ should only require...
> {code:xml}
>   <repositories>
>     <repository>
>       <id>gemstone-release</id>
>       <name>GemStone Maven RELEASE Repository</name>
>       <url>http://dist.gemstone.com/maven/release</url>
>       <snapshots>
>         <enabled>true</enabled>
>         <updatePolicy>always</updatePolicy>
>       </snapshots>
>     </repository>
>     <repository>
>       <id>libs-release</id>
>       <name>Spring Maven libs-release Repository</name>
>       <url>http://repo.spring.io/libs-release</url>
>     </repository>
>   </repositories>
> {code}
> For instance, the "obscure" *jline-1.0.S2-B.jar* dependency is "resolvable" from, for
instance...
> http://repo.spring.io/libs-release/net/sourceforge/jline/jline/1.0.S2-B/jline-1.0.S2-B.jar
> NOTE: by default, and unlike Gradle, Maven searches "Maven Central".
> 2. Add proper "scopes", "optional" settings and "exclusions" to the
> dependencies declared in the POM.
> 3.  Many of the "explicitly" declared dependencies (e.g. spring-beans) need
> to be removed; Maven will resolve dependencies transitively.
> As an example, _Apache Geode's_ Maven POM file should be very similar to the {{Pivotal
GemFire}} Maven POM file, as recently updated and validated for *GemFire 8.2* (see attached
{{gemfire-8.2.0.pom}} file for further details and reference).  This is particularly important
where _Apache Geode_ and _Pivotal GemFire_ intersect.
> There maybe other issues with the POM file that need to be included within the "scope"
of this +bug+ as well and should be included as such, otherwise this JIRA should *+not+* be
marked "complete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message