Return-Path: X-Original-To: apmail-geode-issues-archive@minotaur.apache.org Delivered-To: apmail-geode-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4751182E8 for ; Tue, 19 Jan 2016 19:22:42 +0000 (UTC) Received: (qmail 36000 invoked by uid 500); 19 Jan 2016 19:22:42 -0000 Delivered-To: apmail-geode-issues-archive@geode.apache.org Received: (qmail 35973 invoked by uid 500); 19 Jan 2016 19:22:42 -0000 Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list issues@geode.incubator.apache.org Received: (qmail 35963 invoked by uid 99); 19 Jan 2016 19:22:42 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 19:22:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6C52AC32C1 for ; Tue, 19 Jan 2016 19:22:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.979 X-Spam-Level: X-Spam-Status: No, score=0.979 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id o6xOfJQfVuTE for ; Tue, 19 Jan 2016 19:22:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 017E923016 for ; Tue, 19 Jan 2016 19:22:40 +0000 (UTC) Received: (qmail 35043 invoked by uid 99); 19 Jan 2016 19:22:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 19:22:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E96CD2C1F5D for ; Tue, 19 Jan 2016 19:22:39 +0000 (UTC) Date: Tue, 19 Jan 2016 19:22:39 +0000 (UTC) From: "Dan Smith (JIRA)" To: issues@geode.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GEODE-310) HDFSStore API should be more consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-310: ---------------------------- Component/s: hdfs > HDFSStore API should be more consistent > --------------------------------------- > > Key: GEODE-310 > URL: https://issues.apache.org/jira/browse/GEODE-310 > Project: Geode > Issue Type: Bug > Components: hdfs > Reporter: Kirk Lund > Assignee: Ashvin > > The public interface for HDFSStore has inconsistencies between method names and constants giving default values and between HDFSStore and other entities such as Region and GatewaySender. These need to be made consistent. A decision also needs to be made whether to include units in the attribute names. > Mismatches between method names and default values: > -- HDFSStoreFactory setBatchInterval HDFSStore.DEFAULT_BATCH_INTERVAL_MILLIS > -- HDFSStoreFactory.setBatchSize HDFSStore.DEFAULT_BATCH_SIZE_MB > -- HDFSStoreFactory.setBufferPersistent GatewaySender.DEFAULT_PERSISTENCE_ENABLED > -- HDFSStoreFactory.setDispatcherThreads GatewaySender.DEFAULT_HDFS_DISPATCHER_THREADS > -- HDFSStoreFactory.setInputFileSizeMax HDFSStore.DEFAULT_INPUT_FILE_SIZE_MAX_MB > -- HDFSStoreFactory.setMajorCompactionInterval HDFSStore.DEFAULT_MAJOR_COMPACTION_INTERVAL_MINS > -- HDFSStoreFactory.setMaxMemory GatewaySender.DEFAULT_MAXIMUM_QUEUE_MEMORY > -- HDFSStoreFactory.setPurgeInterval HDFSStore.DEFAULT_OLD_FILE_CLEANUP_INTERVAL_MINS > -- HDFSStoreFactory.setWriteOnlyFileRolloverSize HDFSStore.DEFAULT_WRITE_ONLY_FILE_SIZE_LIMIT > HDFSStore uses "synchronousDiskWrite" where Region and GatewaySender use "diskSynchronous" > This came up during some of the testing and hydra support for HDFS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)