Mailing-List: contact issues-help@geode.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.incubator.apache.org
Date: Fri, 8 Jan 2016 04:40:50 +0000 (UTC)
From: "Anthony Baker (JIRA)" <jira@apache.org>
To: issues@geode.incubator.apache.org
Message-ID: <JIRA.12857078.1439945898000.54020.1452228050573@Atlassian.JIRA>
In-Reply-To: <JIRA.12857078.1439945898000@Atlassian.JIRA>
References: <JIRA.12857078.1439945898000@Atlassian.JIRA>
 <JIRA.12857078.1439945898289@arcas>
Subject: [jira] [Updated] (GEODE-229) Javadocs for
 DiskStoreFactory.setCompactionThreshold are incorrect
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/GEODE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Baker updated GEODE-229:
--------------------------------
    Fix Version/s: 1.0.0-alpha1

> Javadocs for DiskStoreFactory.setCompactionThreshold are incorrect
> ------------------------------------------------------------------
>
>                 Key: GEODE-229
>                 URL: https://issues.apache.org/jira/browse/GEODE-229
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.0.0-alpha1
>
>
> The javadocs for compaction-threshold imply that we compact as soon as the amount of garbage is equal or greater than the threshold.
> From DiskStoreFactory?.setCompactionThreshold
> {noformat}
> When the amount of garbage in an oplog exceeds this percentage then when a compaction
>    * is done this garbage will be cleaned up freeing up disk space. Garbage is created by
>    * entry destroys, entry updates, and region destroys.
> {noformat}
> However, looking at the code, it looks like we actually trigger compaction when the amount of non-garbage data is equal or less than the threshold:
> Here Oplog.needsCompaction, it looks like its saying the oplog needs compaction if the live count is less than the threshold.
> {code}
> long rvHWMtmp = this.totalCount.get();
>     if (rvHWMtmp > 0) {
>       long tlc = this.totalLiveCount.get();
>       if (tlc < 0) {
>         tlc = 0;
>       }
>       double rv = tlc;
>       double rvHWM = rvHWMtmp;
>       if (((rv / rvHWM) * 100) <= parent.getCompactionThreshold()) {
>         return true;
>       }
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)