geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-798) OffHeapStorageJUnitTest.testCreateOffHeapStorage should not create a real cache
Date Wed, 20 Jan 2016 19:11:39 GMT


ASF subversion and git services commented on GEODE-798:

Commit 27f9c0e8775d50981241a67d792abb3e94adb939 in incubator-geode's branch refs/heads/develop
from [~dschneider]
[;h=27f9c0e ]

GEODE-798: change unit test to not create a real cache

testCreateOffHeapStorage now uses mocks.
Also a LocalStatisticsFactory can now be created without starting a sampler.
This allows it to be used as a light weight StatisticsFactory compared to InternalDistributedSystem.
The nice thing compared to a mocked StatisticsFactory is it will still create functional Statistics

> OffHeapStorageJUnitTest.testCreateOffHeapStorage should not create a real cache
> -------------------------------------------------------------------------------
>                 Key: GEODE-798
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
> The OffHeapStorageJUnitTest testCreateOffHeapStorage method creates a real cache that
is then used to obtain a StatisticsFactory and DistributedSystem to pass to createOffHeapStorage.

> It should instead create a mocked StatisticsFactory and DistributedSystem.

This message was sent by Atlassian JIRA

View raw message