geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-680) Chunk class refactoring encountered while writing unit tests.
Date Wed, 16 Dec 2015 23:35:46 GMT

    [ https://issues.apache.org/jira/browse/GEODE-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061134#comment-15061134
] 

ASF GitHub Bot commented on GEODE-680:
--------------------------------------

GitHub user sboorlagadda opened a pull request:

    https://github.com/apache/incubator-geode/pull/61

    GEODE-680: Chunk refactoring encountered while writing unit tests.

    1) Promoted constant fields to default access level.
    2) Modified getAddressForReading to delegate to getUnsafeAddress.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sboorlagadda/incubator-geode GEODE-680

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 41b39b10f5ae73229527b8c562b6b7a28b9f8ad5
Author: Sai Boorlagadda <sboorlagadda@pivotal.io>
Date:   2015-12-16T21:03:19Z

    GEODE-680: Chunk refactoring encountered while writing unit tests.
    
    1) Promoted constant fields to default access level.
    2) Modified getAddressForReading to delegate to getUnsafeAddress.

----


> Chunk class refactoring encountered while writing unit tests.
> -------------------------------------------------------------
>
>                 Key: GEODE-680
>                 URL: https://issues.apache.org/jira/browse/GEODE-680
>             Project: Geode
>          Issue Type: Improvement
>          Components: core
>            Reporter: Sai Boorlagadda
>            Assignee: Sai Boorlagadda
>
> Good to have Chunk refactoring encountered while writing unit tests
> 1. Promote REF_COUNT_OFFSET to at-least protected access level and use it in GemFireChunkJUnitTest
- search by REF_COUNT_OFFSET in the comments.
> 2. Promote MAX_REF_COUNT to at-least protected access level and use it in GemFireChunkJUnitTest.retainShouldThrowExceptionAfterMaxNumberOfTimesRetained
> 3. Promote IS_SERIALIZED_BIT & IS_COMPRESSED_BIT to at-least protected level and
use it in GemFireChunkJUnitTest - search by IS_SERIALIZED_BIT in the comments
> 4. Chunk.getAddressForReading - can delete to Chunk.getUnsafeAddress, as both the methods
are similar and `getUnsafeAddress` has more assert checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message