geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-624) SimpleMemoryAllocatorLifecycleListenerJUnitTest needs coverage of invokeAfterReuse
Date Fri, 11 Dec 2015 00:00:14 GMT

    [ https://issues.apache.org/jira/browse/GEODE-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051883#comment-15051883
] 

ASF GitHub Bot commented on GEODE-624:
--------------------------------------

GitHub user gemzdude opened a pull request:

    https://github.com/apache/incubator-geode/pull/53

    Additional offheap test coverage based on jira ticket GEODE-624

    New unit test for RefCountChangeInfo
     Modified format of stack trace maintained within RefCountChangeInfo
     Test coverage for LifeCycleListener and RefCountChangeInfo
     Removed comments added during testing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-624

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 602c354cd00541ee00c5ec7774a7cd5564035483
Author: Scott Jewell <sjewell@pivotal.io>
Date:   2015-12-04T21:06:58Z

    New unit test for RefCountChangeInfo

commit 4815d83f178fc3797f9fbcfb0725bf6f4ddde463
Author: Scott Jewell <sjewell@pivotal.io>
Date:   2015-12-04T21:09:44Z

    Modified format of stack trace maintained within RefCountChangeInfo

commit 8d30989c4a55046673f61fc17fb35fb58dcab1e3
Author: Scott Jewell <sjewell@pivotal.io>
Date:   2015-12-10T18:30:18Z

    Test coverage for LifeCycleListener and RefCountChangeInfo
    
    Renamed SimpleMemoryAllocatorLifeCycleListener to LifeCycleListener
    New methods in RefCountChangeInfo for unit testing
    Renamed ReferenceCountHelper method isDuplicate to isSameCaller

commit b8337a6366950aa4f3b233bd0a4f24afae76e882
Author: Scott Jewell <sjewell@pivotal.io>
Date:   2015-12-10T19:01:58Z

    Removed comments added during testing

commit a2a829970f0e876f20c2651429a6784533713eec
Author: Scott Jewell <sjewell@pivotal.io>
Date:   2015-12-10T22:24:52Z

    Moved inner class SameHashDifferentString from RefCountChangeInfo to RefCountChangeInfoJUnit
    Remove method setSameHasDifferentString from RefCountChangeInfo
    Modified unit test to use new inner class

----


> SimpleMemoryAllocatorLifecycleListenerJUnitTest needs coverage of invokeAfterReuse
> ----------------------------------------------------------------------------------
>
>                 Key: GEODE-624
>                 URL: https://issues.apache.org/jira/browse/GEODE-624
>             Project: Geode
>          Issue Type: Sub-task
>          Components: offheap
>            Reporter: Darrel Schneider
>            Assignee: Scott Jewell
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message