geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-77) Replace JGroups 2.2.9
Date Fri, 13 Nov 2015 19:46:11 GMT


ASF subversion and git services commented on GEODE-77:

Commit f57eb8b15e042e87576b117e093180bba256f90f in incubator-geode's branch refs/heads/feature/GEODE-77
from [~bschuchardt]
[;h=f57eb8b ]

GEODE-77: faster initiation of suspect processing on crashed member
TCPConduit's was not initiating suspect processing when a member crashed.
 This was due to not having the check in the normal (amt < 0) check for a socket error.

In testing this fix with ReconnectDUnitTest I found that the change exposed some problems
in GMSJoinLeave that were keeping reconnect from happening as fast as it should:

1. The reconnecting member was processing a RemoveMember message intended for its old incarnation.
 This caused it to invoke forceDisconnect() but the concurrent join() attempt did not notice
this and continued to try to connect until it timed out.

2. ViewCreator was removing the new member from the view if its old ID was being declared
crashed in the same view because of the way InternalDistributedMember.compareTo() works with
viewless identifiers.

This change-set also gets rid of a bunch of references to JGroups scattered around in the
code and removes references to JGroups classes from GMSMembershipManager, moving the code
requiring these refs to the quorum checker.

> Replace JGroups 2.2.9
> ---------------------
>                 Key: GEODE-77
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>            Priority: Blocker
>             Fix For: 1.0.0-incubating
>         Attachments: GEODE-MembershipManagerFunctionalSpecification-130715-1604-29054.pdf
> The JGroups 2.2.9 sources that are currently included in Geode must be replaced in order
for Geode to leave incubation.  A wiki document has been created to investigate alternatives.

This message was sent by Atlassian JIRA

View raw message