geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-93) Entry count stats are incorrect with PR with entry eviction and async disk
Date Thu, 23 Jul 2015 16:19:05 GMT


ASF subversion and git services commented on GEODE-93:

Commit b8686b52b97f8cbe1b46df8cda81a5e2bbd4cfaf in incubator-geode's branch refs/heads/feature/GEODE-9
from [~upthewaterspout]
[;h=b8686b5 ]

GEODE-56 Decrementing bytesOverflowedOnDisk when an update happens to an evicted entry.

For persistent regions, we were correctly updating this stat. But for
non persistent regions we did not read the old size on disk, so we were
not updating the stat.

If the entry was in the async queue, we only increment the stat once
when the final value is actually written to disk. So we will only
decrement the stat if the oldValue is not pending asynchronous write to

I'm still seeing issues with the entryCount. I've tracked this down to
what I think is a problem with tombstones. It appears when we modify an
entry that is a tombstone, we increment the entry count once for the new
value, and once for removing the tombstone. I've filed GEODE-92 and
GEODE-93 for the issues I've found with this new test.

> Entry count stats are incorrect with PR with entry eviction and async disk
> --------------------------------------------------------------------------
>                 Key: GEODE-93
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Dan Smith
>         Attachments: 0001-Test-that-demonstrates-incorrect-entriesOnDisk-and-e.patch
> I discovered this while writing a unit test for GEODE-56. It looks like when doing operations
on a PR with entry eviction of 1, overflow to disk, and asynchronous persistence, the stats
fo entries in memory and entries on disk are incorrect. Entries in memory is too high and
entriesOnDisk goes negative.

This message was sent by Atlassian JIRA

View raw message