geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Stevenson (JIRA)" <>
Subject [jira] [Commented] (GEODE-38) Gfsh init script ignored
Date Fri, 29 May 2015 07:57:17 GMT


Neil Stevenson commented on GEODE-38:

  Ok, let me know if I need to do anything except wait

  The java/src/main code isn't much, maybe 10 lines or so. Two new 
classes in java/src/test though.

  While there are JUnit tests, but quite a bit of fiddling to get those 
to be clean. Much of the original code
for Gfsh isn't set up in a manner convenient for unit test, as there's 
private static variables set once, so
there's a bit of reflection nonsense going on to change them. I'm not 
entirely happy about having to do
this in a test, but it's better in the short term than refactoring the code.

  And that is perhaps the wider issue, some of the code isn't set up in 
a unit testable way. Perhaps an
enhancement request in itself.


> Gfsh init script ignored
> ------------------------
>                 Key: GEODE-38
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: management & tools
>    Affects Versions: 1.0.0-incubating
>            Reporter: Neil Stevenson
>            Priority: Trivial
>         Attachments: 0001-Initial-version.patch
>   Original Estimate: 168h
>  Remaining Estimate: 168h
> Gfsh launcher script implies an init file can be used. This was possible in GF 6.6, but
wasn't implemented in the transition to the new Gfsh in GF 7.0 onwards.
> From "gemfire-assembly/src/main/dist/bin/gfsh.bat " :
> "
> #
> # Copy default .gfshrc to the home directory. Uncomment if needed.
> #
> #if [ ! -f $HOME/.gemfire/.gfsh2rc ]; then
> #  cp $GEMFIRE/defaultConfigs/.gemfire/.gfsh2rc $HOME
> #fi
> "
> If this file is specified, it is currently ignored.

This message was sent by Atlassian JIRA

View raw message