geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wes Williams (JIRA)" <>
Subject [jira] [Created] (GEODE-20) DISCUSSION of Pull Request to Fix REST API
Date Mon, 11 May 2015 17:40:59 GMT
Wes Williams created GEODE-20:

             Summary: DISCUSSION of Pull Request to Fix REST API
                 Key: GEODE-20
             Project: Geode
          Issue Type: Bug
          Components: general
    Affects Versions:
            Reporter: Wes Williams
            Assignee: William Markito Oliveira
             Fix For:

GitHub user wwilliams-pivotal opened a pull request:

    Allow REST web API to be launched. Eliminate duplicate code

    - Refactored duplicate code into a common class
    - Changed the return for the web rest dev api to return gemfire-web-api instead of gemfire-web
    - Applied standard formatting conventions against the existing classes per code policy
    - Added unit test to check for existence of gemfire-web-api jar

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2

To make the review simpler, the only two material changes are below. All of the rest is/ (should
be) duplicate code refactoring or source code formatting according to the conventions that
Anthony sent out earlier.

-      //Find developer REST WAR file
-      final String gemfireAPIWar =  getGemFireAPIWarLocation(gemfireHome);
+      // Find developer REST WAR file
+      final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();


-     final String gemfireAPIWar =  getGemFireAPIWarLocation(gemfireHome);
-    if(gemfireAPIWar == null){
-"Unable to find GemFire Developer REST API WAR file; the Developer REST
API for GemFire will not be exported and accessible.");
+    final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
+    if (gemfireAPIWar == null) {

This message was sent by Atlassian JIRA

View raw message