From dev-return-32330-archive-asf-public=cust-asf.ponee.io@geode.apache.org Fri Nov 1 02:34:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AAB9F180629 for ; Fri, 1 Nov 2019 03:34:05 +0100 (CET) Received: (qmail 60142 invoked by uid 500); 1 Nov 2019 02:34:04 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 60048 invoked by uid 99); 1 Nov 2019 02:34:04 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.42) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2019 02:34:04 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id CA3BA59FA for ; Fri, 1 Nov 2019 02:34:03 +0000 (UTC) Received: by mail-ed1-f72.google.com with SMTP id a3so5557926eda.0 for ; Thu, 31 Oct 2019 19:34:03 -0700 (PDT) X-Gm-Message-State: APjAAAUjc5uyYlh3dkJEzsGQLt8wPv/yX00Bsjo3cXkzmOe9/nw04+pM fPoZtEYAs+PlFLu88u+B7vRR6HbfCaRpS19gUsz18HBIc+/ORb+Z/jp/vMTVpws9vOWbmnKg1fv T45jH69as+YUF8Dcuaw4HR07ctBhr+aitTTIoaM+spGH0YdGDzY//G3c= X-Received: by 2002:a17:906:300a:: with SMTP id 10mr7532484ejz.104.1572575642557; Thu, 31 Oct 2019 19:34:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqGMkqvUQR7VDiuuuGJ8BbdOAsCj6WhRksra/Tx3OJmd1+gxPvXBwXPhtQqqG+g0hB+MxcFiL7qogwd0T/7yc= X-Received: by 2002:a17:906:300a:: with SMTP id 10mr7532480ejz.104.1572575642453; Thu, 31 Oct 2019 19:34:02 -0700 (PDT) MIME-Version: 1.0 References: <1a219de6-20ab-0608-dbb7-6b8fe171f717@pivotal.io> In-Reply-To: From: Nabarun Nag Date: Thu, 31 Oct 2019 19:33:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Re: unable to push To: geode Content-Type: multipart/alternative; boundary="0000000000008d21b705963fccb3" --0000000000008d21b705963fccb3 Content-Type: text/plain; charset="UTF-8" It is how Github branch protection is designed. This is my explanation from the information provided by you : - The Pull Request you mentioned had 11 commits and when you tried to merged it, I assume you tried to squash it to a single commit. It generates a new SHA. - When you are pushing that SHA to origin develop, GitHub could not find that SHA in the list of approved Pull Requests SHAs. - This is why it blocked your push to develop origin. Workaround: - This would have worked if there was only one commit in the Pull Request: - If you still need to use the command line, you can create the Pull Request with only one commit (after squashing). - I generally, commit --amend over the last commit SHA and then force push, so that it stays as a single commit. Regards Naba On Thu, Oct 31, 2019 at 6:56 PM Bruce Schuchardt wrote: > I just want to know why my PR that passed the tests and was approved > couldn't be pushed from the command line Naba > > On 10/31/19 5:11 PM, Nabarun Nag wrote: > > Hi Bruce, > > > > This was what was discussed in multiple email chains last week. GitHub > > branch protection was enabled on the develop branch. > > > > Command-line and the merge button on the website have the same effect. > > This > > has now being implemented in a lot of Apache projects and we are > > implementing it as the geode community is growing, to prevent > > unintentional > > red pipelines. > > > > It is a small inconvenience paid for saving a lot of our time in > detecting > > which commit caused the red pipeline or which commit introduced a flaky > > test. Our time can be used in other productive work. > > > > Kindly reconsider as a majority of us have already moved to the GitHub > > merge system on the website. > > > > Regards > > Nabarun > > > > > > > > On Thu, Oct 31, 2019 at 4:45 PM Robert Houghton > > wrote: > > > >> Was there a pull request for this SHA? > >> > >> On Thu, Oct 31, 2019, 16:36 Bruce Schuchardt > >> wrote: > >> > >>> I just completed GEODE-7358 and was prevented from pushing from the > >>> command-line. The Merge button on github worked, but why can't I have > >>> command-line control of the process? I don't like giving control of my > >>> merge to a web-site button. We should revert this change! > >>> > >>> > >>> geode> git push --no-verify origin develop > >>> Enumerating objects: 352, done. > >>> Counting objects: 100% (352/352), done. > >>> Delta compression using up to 8 threads > >>> Compressing objects: 100% (192/192), done. > >>> Writing objects: 100% (223/223), 153.60 KiB | 9.04 MiB/s, done. > >>> Total 223 (delta 106), reused 59 (delta 3) > >>> remote: Resolving deltas: 100% (106/106), completed with 93 local > >> objects. > >>> remote: error: GH006: Protected branch update failed for > >>> refs/heads/develop. > >>> remote: error: 4 of 4 required status checks are expected. At least 1 > >>> approving review is required by reviewers with write access. > >>> To ssh://github.com/apache/geode.git > >>> ! [remote rejected] develop -> develop (protected branch hook > >>> declined) > >>> error: failed to push some refs to 'ssh:// > >> git@github.com/apache/geode.git' > >>> > --0000000000008d21b705963fccb3--